Bug fix for scaled_float in encodePoint method
#18952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prudhvi Godithi <[email protected]>
github-actions
bot
added
enhancement
prudhvigodithi
changed the title
scaled_float in encodePoint methodscaled_float in encodePoint method
Signed-off-by: Prudhvi Godithi <[email protected]>
Signed-off-by: Prudhvi Godithi <[email protected]>
|
Adding @harshavamsi, @kkewwei, @msfroh to please take a look. |
harshavamsi
approved these changes
Aug 7, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18952 +/- ##
============================================
+ Coverage 72.89% 73.03% +0.14%
- Complexity 69318 69384 +66
============================================
Files 5642 5642
Lines 318636 318637 +1
Branches 46107 46107
============================================
+ Hits 232254 232708 +454
+ Misses 67540 67133 -407
+ Partials 18842 18796 -46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kkewwei
reviewed
Aug 7, 2025
modules/mapper-extras/src/main/java/org/opensearch/index/mapper/ScaledFloatFieldMapper.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Prudhvi Godithi <[email protected]>
kkewwei
approved these changes
Aug 7, 2025
|
❕ Gradle check result for 8350432: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
cwperks
approved these changes
Aug 7, 2025
github-project-automation
bot
moved this from In Progress
to Done
in Performance Roadmap
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 7, 2025
* Fix scaled float bug Signed-off-by: Prudhvi Godithi <[email protected]> * Update changelog Signed-off-by: Prudhvi Godithi <[email protected]> * Update changelog Signed-off-by: Prudhvi Godithi <[email protected]> * Add clamps Signed-off-by: Prudhvi Godithi <[email protected]> --------- Signed-off-by: Prudhvi Godithi <[email protected]> (cherry picked from commit 35a91c1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
prudhvigodithi
pushed a commit
that referenced
this pull request
Aug 7, 2025
* Fix scaled float bug * Update changelog * Update changelog * Add clamps --------- (cherry picked from commit 35a91c1) Signed-off-by: Prudhvi Godithi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
RajatGupta02
pushed a commit
to RajatGupta02/OpenSearch
that referenced
this pull request
Aug 18, 2025
…t#18952) * Fix scaled float bug Signed-off-by: Prudhvi Godithi <[email protected]> * Update changelog Signed-off-by: Prudhvi Godithi <[email protected]> * Update changelog Signed-off-by: Prudhvi Godithi <[email protected]> * Add clamps Signed-off-by: Prudhvi Godithi <[email protected]> --------- Signed-off-by: Prudhvi Godithi <[email protected]>
kh3ra
pushed a commit
to kh3ra/OpenSearch
that referenced
this pull request
Sep 5, 2025
…t#18952) * Fix scaled float bug Signed-off-by: Prudhvi Godithi <[email protected]> * Update changelog Signed-off-by: Prudhvi Godithi <[email protected]> * Update changelog Signed-off-by: Prudhvi Godithi <[email protected]> * Add clamps Signed-off-by: Prudhvi Godithi <[email protected]> --------- Signed-off-by: Prudhvi Godithi <[email protected]>
vinaykpud
pushed a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Sep 26, 2025
…t#18952) * Fix scaled float bug Signed-off-by: Prudhvi Godithi <[email protected]> * Update changelog Signed-off-by: Prudhvi Godithi <[email protected]> * Update changelog Signed-off-by: Prudhvi Godithi <[email protected]> * Add clamps Signed-off-by: Prudhvi Godithi <[email protected]> --------- Signed-off-by: Prudhvi Godithi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This bug was introduced part of this PR #18896, following the same pattern for
encodePoint(Object value, boolean roundUp)similar totermQueryinScaledFloatFieldMapper.Related Issues
Resolves #18546
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.